Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove enableKeys from OrbitControls #171

Merged
merged 2 commits into from
Feb 12, 2022
Merged

Remove enableKeys from OrbitControls #171

merged 2 commits into from
Feb 12, 2022

Conversation

wooster0
Copy link
Contributor

@wooster0 wooster0 commented Feb 12, 2022 •
edited
Loading

Why

This is no longer being used, Ctrl+F it in https://github.com/mrdoob/three.js/blob/dev/examples/js/controls/OrbitControls.js.

For all instances, see https://github.com/mrdoob/three.js/search?q=enableKeys.
It only seems to be used in the experimental CameraControls.

What

I've removed it.

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

@wooster0 wooster0 marked this pull request as ready for review February 12, 2022 13:24
joshuaellis
joshuaellis approved these changes Feb 12, 2022
View reviewed changes
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! ⭐

@joshuaellis joshuaellis merged commit 2a81596 into three-types:master Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wooster0 @joshuaellis